Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #72, #91 — getting git remote url #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexanderadam
Copy link

@alexanderadam alexanderadam commented Oct 7, 2020

Hi @karlfreeman,

I know that this likely won't be merged (I saw the list of open PRs) but maybe it will help someone else.

The problem with issues #72 and #91 was, that the subrepository in the build directory can only be initialized the first time because there's no other git repository in the build folder yet. Afterwards get_remote_url will only get the data from git repository of the build folder, which might have a totally different origin name or url. Thus the chdir('..') to get to the main repository again.

The dependencies really should be updated, too (but somebody else already took care on on this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant