fixes #72, #91 — getting git remote url #140
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @karlfreeman,
I know that this likely won't be merged (I saw the list of open PRs) but maybe it will help someone else.
The problem with issues #72 and #91 was, that the subrepository in the build directory can only be initialized the first time because there's no other git repository in the
build
folder yet. Afterwardsget_remote_url
will only get the data from git repository of thebuild
folder, which might have a totally different origin name or url. Thus thechdir('..')
to get to the main repository again.The dependencies really should be updated, too (but somebody else already took care on on this).