smscalls: make checking for keys stricter #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sort of reverts karlicoss#287, but also makes some other improvements this allows us to remove some of the Optional's to make downstream consumers easier to write. However, this keeps the return type as a Res (result, with errors), so downstream consumers will have to handle those incase the schema ever changes (highly unlikely) also added the 'call_type/message_type' with a comment there describing the values I left 'who' Optional I believe it actually should be - its very possible for there to be no contact name, added a check incase its '(Unknown)' which is what my phone sets it to
|
I left |
This was referenced Apr 15, 2023
Merged
|
awesome, thanks! Yeah same, not really a fan of python enums |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort of reverts #287, but also makes some other improvements
this allows us to remove some of the Optional's to
make downstream consumers easier to write. However,
this keeps the return type as a Res (result, with errors),
so downstream consumers will have to handle those incase
the schema ever changes (highly unlikely)
also added the 'call_type/message_type' with a comment
there describing the values
I left 'who' Optional I believe it actually should be -
its very possible for there to be no contact name, added
a check incase its '(Unknown)' which is what my phone
sets it to