Keep empty query parameters.

src/promnesia/cannon.py

@@ -271,7 +271,7 @@ def transform_split(split: SplitResult):
  netloc = canonify_domain(split.netloc)
 
  path = split.path
- qparts = parse_qsl(split.query)
+ qparts = parse_qsl(split.query, keep_blank_values=True)
 
  fragment = split.fragment
 
@@ -319,7 +319,7 @@ def iter_rules():
  to = to + ('', )
 
  (netloc, path, qq) = [t.format(**gd) for t in to]
- qparts.extend(parse_qsl(qq)) # TODO hacky..
+ qparts.extend(parse_qsl(qq, keep_blank_values=True)) # TODO hacky..
  # TODO eh, qparts should really be a map or something...
  break
 

tests/cannon.py

@@ -294,3 +294,11 @@ def test_error():
  with pytest.raises(CanonifyException):
  # borrowed from https://bugs.mageia.org/show_bug.cgi?id=24640#c7
  canonify('https://example.com\uFF03@bing.com')
+
+@pytest.mark.parametrize("url,expected", [
+ ('https://news.ycombinator.com/item?id=', 'news.ycombinator.com/item?id='),
+ ('https://www.youtube.com/watch?v=hvoQiF0kBI8&list&index=2',
+ 'youtube.com/watch?v=hvoQiF0kBI8&list='),
+])
+def test_empty_query_parameter(url, expected):
+ assert canonify(url) == expected