Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Method names #1

Closed
kevinruscoe opened this issue Oct 25, 2015 · 0 comments
Closed

Suggestion: Method names #1

kevinruscoe opened this issue Oct 25, 2015 · 0 comments
Assignees

Comments

@kevinruscoe
Copy link

Just a suggestion, but Laravel's conventions are generally put(), get(), has(), all().

Would it make more sense, from a Laravel point of view, but use these names?

Theme::getThemes(); becomes Theme:all()
Theme::themeExists('theme-namespace'); becomes Theme::has('theme-namespace');

Other than that, terrific job, can't wait to use this!

@karlomikus karlomikus self-assigned this Oct 31, 2015
karlomikus added a commit that referenced this issue Oct 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants