Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

feat: demonstrate better test failure handling with gulp-util #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brocksamson
Copy link

This pull request will close #33

@dignifiedquire
Copy link
Member

Travis is still unhappy I'm afraid, also rather than ignoring the test please update it such that it passes again.

@brocksamson
Copy link
Author

Its not failing due to my changes... I don't know how it ever passed. The error is

19 07 2016 22:16:57.904:INFO [launcher]: Launching browser Chrome with unlimited concurrency
19 07 2016 22:16:57.912:INFO [launcher]: Starting browser Chrome
19 07 2016 22:16:58.390:ERROR [launcher]: Cannot start Chrome

This is due to the tests targeting chrome, which they did before I made any changes. I don't really know whats wrong, but any build of master right now should fail in the same way as the karma config explicitly targets chrome.

My commit is designed to explicitly show how to clean up the very ugly gulp stack exception that occurs when tests fail within gulp using the recommended configuration. This requires a failing test to demonstrate, which is why I created the test. I can remove the test and people can manually create a broken test to confirm my changes, but the build will still be broken.

I don't know much about travis CI but it seems like this stack overflow article has some information on best steps forward. I'm not really comfortable making this level of change to a project I don't own, especially not as a first commit.

If you want to just close out this pull request that's fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up error reporting trace when tests fail.
2 participants