Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

fix: make configuration options work again #158

Merged
merged 1 commit into from
Mar 16, 2020
Merged

fix: make configuration options work again #158

merged 1 commit into from
Mar 16, 2020

Conversation

csvn
Copy link
Contributor

@csvn csvn commented Aug 16, 2019

This MR will again pass in the config options tunnelIdentifier,
localIdentifier and forceLocal to the npm package that
creates the Browserstack Local tunnel.

Resolves #155 #156

@csvn
Copy link
Contributor Author

csvn commented Aug 16, 2019

I tested this by replacing karma-browserstack-launcher with the Github branch as version in package.json, and it made our pipelines pass once again.

This MR will again pass in the config options `tunnelIdentifier`,
`localIdentifier` and `forceLocal` to the npm package that
creates the Browserstack Local tunnel.

Resolves #155 #156
@csvn
Copy link
Contributor Author

csvn commented Jan 29, 2020

Rebased in latest changes from this repo. Wanted to make sure Travis build does not fail.

@kalamcs kalamcs merged commit 5ec5e03 into karma-runner:master Mar 16, 2020
@csvn csvn deleted the fix-configuration-options branch March 17, 2020 01:01
@michaelfarrell76
Copy link

when will the next version be published? we were relying on this branch on our CI

@csvn
Copy link
Contributor Author

csvn commented Mar 17, 2020

@michaelfarrell76 Sorry! I didn't know anyone else was using my branch. You can probably use "github:karma-runner/karma-browserstack-launcher#master" (or commit hash instead of master) instead until the release, right? Also curious when next publish will be, will be nice to get rid of github version links.

@michaelfarrell76
Copy link

yep we did that :) appreciate your help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config option tunnelIdentifier has no effect
5 participants