Deprecation warning with Jasmine-Core@3.3.0

[Lalem001]

Jasmine-Core 3.3.0 release nodes

Introduce a configuration object to Env deprecating old single use functions

The test fails as well, however I am not sure if that is something that could be fixed here.

HeadlessChrome 0.0.0 (Mac OS X 10.13.6) ERROR: 'DEPRECATION:', 'Setting specFilter directly on Env is deprecated, please use the specFilter option in `configure`'
HeadlessChrome 0.0.0 (Mac OS X 10.13.6) ERROR
  {
    "message": "TypeError: this.deprecated is not a function\n    at Env.throwOnExpectationFailure (/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1079:12)\n    at setOption (/node_modules/karma-jasmine/lib/adapter.js:354:7)\n    at ContextKarma.start (/node_modules/karma-jasmine/lib/adapter.js:343:5)\n    at ContextKarma.loaded (http://localhost:9876/context.js:168:14)\n    at http://localhost:9876/context.html:47:22",
    "str": "TypeError: this.deprecated is not a function\n    at Env.throwOnExpectationFailure (/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:1079:12)\n    at setOption (/node_modules/karma-jasmine/lib/adapter.js:354:7)\n    at ContextKarma.start (/node_modules/karma-jasmine/lib/adapter.js:343:5)\n    at ContextKarma.loaded (http://localhost:9876/context.js:168:14)\n    at http://localhost:9876/context.html:47:22"
  }
HeadlessChrome 0.0.0 (Mac OS X 10.13.6): Executed 0 of 0 ERROR (0.122 secs / 0 secs)

[Lalem001]

After some investigation, it appears the tests failure that results in "this.deprecated is not a function" is caused by client.jasmine configuration being set.

For example, setting such properties on this repo's karma.conf.js causes the error:

module.exports = function (config) {
  config.set({
    frameworks: ['jasmine'],

    files: [
      'src/*.js',
      'test/*.js'
    ],

    browsers: process.env.TRAVIS ? ['Firefox'] : ['Chrome'],

    client: {
      jasmine: {
        random: false,
      }
    },

    autoWatch: true,

    plugins: [
      'karma-firefox-launcher',
      'karma-chrome-launcher',
      require.resolve('./')
    ]
  })
}

This does not absolve karma-jasmine from updating to the new configuration object. I am looking to see if I can figure out a solution.

[Lalem001]

@johnjbarton I had a PR up that fixed the issue, but broke support for jasmine < 3.3.0. Do you want to continue supporting such versions?

[johnjbarton]

Yes, we need a solution where the entire jasmine 3.x series works for a karma-jasmine 2.x.

[Lalem001]

@johnjbarton Any suggestions on how to get the unit tests to test against the different versions of jasmine?

[johnjbarton]

it appears the tests failure that results in "this.deprecated is not a function" is caused by client.jasmine configuration being set.

We need to run down what exactly is the cause here. Which line of code fails, what is the this value on that line, and how is client.jasmine related?

I hope the jasmine config spec did not change in v3.3?

[Lalem001]

The this is incorrect because of Lines 358-361 and Line 372.

#223, resolves the this binding issue. But Jasmine changed the methods that are invoked in these lines to have deprecations notices.

The jasmine config spec actually has changed with 3.3.

Karma-Jasmine's stopOnFailure pointed to throwOnExpectationFailure in jasmines configuration pre 3.3. The new configuration option in Jasmine 3.3 is oneFailurePerSpec

I believe I am close to a PR that handles both cases without deprecation warnings.

[Lalem001]

Regarding the PR I am working on,

While the code itself can handle Jasmine 3.3, I don't like that I need to have the unit tests change their behavior to handle Jasmine@>=3.3.0. Its either branch on the version of jasmine, or have separate sets of unit tests.

[tempoc]

For our project it was yarn killing it.
Saw the problem when running yarn install which resolved jasmine-core to version 3.3.0.
Fixed by running npm install which resolved jasmine-core to version 3.2.1.

(still an issue with 3.3.0, but hopefully the comment helps people who run into this unexpectedly)

[julkue]

I'm also seeing it with ^3.0.0

[FrancescoBorzi]

getting the same warning here, using:

    "jasmine-core": "^3.3.0",
    "jasmine-spec-reporter": "^4.2.1",
    "karma": "^3.1.1",
    "karma-chrome-launcher": "^2.2.0",
    "karma-cli": "^1.0.1",
    "karma-coverage-istanbul-reporter": "^2.0.4",
    "karma-jasmine": "^1.1.2",
    "karma-jasmine-html-reporter": "^1.4.0",
    "karma-junit-reporter": "^1.2.0",

[webmaster128]

Unfortunately the patch from #224 is not released yet

[cenfun]

Could you please publish new version since it's fixed?

[johnjbarton]

Please send a Pull Request to update the documentation for the new release.

[Lalem001]

@johnjbarton Not sure what you are looking for here. The README has a minor update in the PR to correct the invalid configuration value. Are you looking for a section explaining why backward compatibility is lost? And/Or setting the Jasmine 2.0 header to something like Jasmine 2.0 - 3.2 and adding a Jasmine 3.3 header?

[webmaster128]

@Lalem001 All done now and upgrade possible (see e.g. https://github.com/iov-one/iov-core/pull/542/files)

[johnjbarton]

@Lalem001 AFAICT the "Jasmine 2.0 section of the readme is completely incorrect now. The instructions would result in Jasmine 3.3 and jasmine will be loaded as a dep.

I would prefer instructions limited to the latest release (since we don't have resources for corner cases).

[yasiryc]

Any update when the fix would be published? npm still shows 3.3.0 as latest version

[MauricioPenteado]

I fixed it on my side using the follow upgrades:

"jasmine-core": "^3.3.0",
"karma-jasmine": "^2.0.1",
"karma-jasmine-html-reporter": "^1.4.0",

[mowali]

MauricioPenteado: I have the exact setup like yours but still sees error.