Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for debug view with socket.io #12

Closed
wants to merge 2 commits into from

Conversation

pablojim
Copy link
Contributor

@pablojim pablojim commented Dec 2, 2013

Fix for #11

return window.parent.io.sockets[location.protocol + '//' + location.host].transport.name;
};



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this empty line please

@vojtajina
Copy link
Contributor

Awesome. @pablojim can you please correct the commit message to follow our convention (karma-runner.github.io/0.10/dev/git-commit-msg.html) to something like fix: add a check for debug view with socket.io and also, please add Closes #11 into the commit msg body.

Thanks a bunch!

@pablojim pablojim closed this Dec 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants