Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes matches performance issue, github#302 #321

Merged
merged 1 commit into from
May 13, 2022
Merged

fix: fixes matches performance issue, github#302 #321

merged 1 commit into from
May 13, 2022

Conversation

Havunen
Copy link
Contributor

@Havunen Havunen commented May 11, 2022

improve this.matches function performance by converting indexof loop to Set (hashtable) has. O(n) to O(1) fixes: #302

@jginsburgn jginsburgn merged commit e964fa6 into karma-runner:master May 13, 2022
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specFilter causes timeout with large amount of tests
3 participants