Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] fix: Remove getCurrentTransport. #88

Closed

Conversation

dignifiedquire
Copy link
Member

Do not merge into master! This is is only needed for the 0.1 branch.

This is not needed anymore for socket.io 1.3.

Ref karma-runner/karma#1404

Update: This needs to bump the dependency of karma, to ensure that it uses the version with the new socket.io (probably 0.14.0) as otherwise these change could lead to issues with the older versions.

This is not needed anymore for socket.io 1.3.
@maksimr
Copy link
Contributor

maksimr commented May 15, 2015

@dignifiedquire Thanks!!

In which branch I should merge it? I dont see branch 0.1 in karma-jasmine

@dignifiedquire
Copy link
Member Author

@maksimr seems there is only a tag, I would create a new branch based on the tag 0.1.5 which seems the latest version on the 0.1 branch.
As a side note, we really should upgrade the karma client tests..

@maksimr
Copy link
Contributor

maksimr commented May 15, 2015

@dignifiedquire got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants