Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

fix: Remove fs.writeSync as default adapter and add TeamCity setup do… #83

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

kevcenteno
Copy link
Contributor

…cumentation

Closes #38

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kevcenteno
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@kevcenteno
Copy link
Contributor Author

Unrelated build failure: Failure due to npm no longer supporting node v0.10. Maybe the CI build should remove this test.

@kevcenteno
Copy link
Contributor Author

Might also fix #25

@kevcenteno
Copy link
Contributor Author

@dignifiedquire Any thoughts on this?

@dizel3d
Copy link
Contributor

dizel3d commented Oct 12, 2017

@kevcenteno, it works, thank you!

Generally, the PR just reverted the fix d8d9e70, which isn't actual anymore. (#32 (comment) explains why.) So I look forward to merging.

@dignifiedquire, ping.

@dizel3d
Copy link
Contributor

dizel3d commented Oct 12, 2017

@kevcenteno, rebase your PR to actual master, please, to fix Travis CI build.

@kevcenteno
Copy link
Contributor Author

Rebased

@kevcenteno
Copy link
Contributor Author

@dignifiedquire @dizel3d Tests are passing and ready for merge

@dignifiedquire dignifiedquire merged commit 6390b53 into karma-runner:master Jan 4, 2018
@dignifiedquire
Copy link
Member

Thank you :octocat:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants