Upgrade to socket.io 1.0

[vojtajina]

No description provided.

[pkozlowski-opensource]

We seem to be having an issue for this one already: #1147

[pkozlowski-opensource]

And another one :-)
#252

Guess would be good to centralise the discussion in one place.

[dhimil]

Fix: #1258

[mgol]

Just commenting for subscribers to this issue that this affects BrowserStack stability. I've reported #1284 not noticing this one.

[juliemr]

This also seems to affect BrowserStack stability outside of OS X - see errors on the angular Travis CI such as https://travis-ci.org/angular/angular.js/jobs/48153879

[sindresorhus]

Because Karma is using a very outdated Socket.io version, users have to download a 8 MB useless file (karma/node_modules/socket.io/node_modules/socket.io-client/node_modules/active-x-obfuscator/node_modules/zeparser/benchmark.html), which is not apparent in later Socket.io versions... Please update.

[dignifiedquire]

@ everyone around here, There is working version with the latest socket.io in this PR #1404 But I need some real world tests to be sure it works, so please go ahead and try it out and report bugs 💣

[mgol]

What has happened? Karma 0.12.33 includes socket.io 0.9.16 whereas the previous 0.12.32 included socket.io 1.3.5... old bugs are back 😕

[dignifiedquire]

karma@0.12.32 was an accidental release, which released the canary version into the stable branch, which it shouldn't have (that's why there is no tag of it on github or anything like that..)
0.12.33 was the first release to actually mirror what is on master on github again.
I'm going to merge the socket.io upgrade into canary today, so that way we 0.13.0-rc.1 should have the latest socket.io and as soon as I've fixed all the integration test issues I want to pull this into stable.

[dignifiedquire]

Also, I'm very sorry for all this chaos @mzgol :(

[mgol]

Thanks for the info, @dignifiedquire; I didn't know Karma 0.12.32 was not released from master.

[dignifiedquire]

I just published 0.13.0-rc.1 it has the latest socket.io version, please take it for a spin and report all the bugs

[mgol]

@dignifiedquire I can't currently test this version as grunt-karma declares a karma peerDependency at ~0.12.0 which prevents it from even installing.

[dignifiedquire]

😢 I hate peer dependencies..

[necramirez]

Hi! I'd like to suggest to change the dependency on socket.io to NOT be a specific version. Right now, package.json specifies it to be EXACTLY 0.9.16: https://github.com/karma-runner/karma/blob/v0.12.36/package.json#L211

However, socket.io has no such release https://github.com/Automattic/socket.io/releases/tag/0.9.16 (maybe they accidentally deleted it?). Browsing the socket.io releases list, after 0.9.15, it skips 0.9.16, but there is a 0.9.17.

I think this should be fixed immediately, before even the upgrade to socket.io 1.x.

[dignifiedquire]

This is already fixed in the canary branch: https://github.com/karma-runner/karma/blob/canary/package.json#L214

[necramirez]

I was suggesting that there be a hotfix, since master is currently broken, and I don't know how soon the next release will be.

Unless there will be a release in the next couple of days?