Support node 4.0

[charlierudolph]

https://nodejs.org/en/blog/release/v4.0.0/

[charlierudolph]

Hmm issue may be just node-gyp

[lygstate]

Why would be node-gyp?

[charlierudolph]

Nevermind appears to be related to the install scripts of socket-io dependencies similar to #1571

[dignifiedquire]

Make some noise on socket.io so they finally bumpt their dependencies to resolve this :( socketio/socket.io#2228 (comment)

[3rd-Eden]

The root cause of this issue is how horrible the UX of npm is. The build is probably just working fine, but due to the npm output vomit which complains about errors in optional dependencies, it makes it look like the installation failed instead of actually being successful.

[dignifiedquire]

@3rd-Eden yes I know but everyone thinks the install failed and then comes over here complaining. And even worse, it's actually causing test builds to fail: #1579 (comment)

[talltyler]

Now that this is fixed can you please release a new version with a updated socket.io.

[dignifiedquire]

@talltyler what makes you think this is fixed? There hasn't been a socket.io release that fixes this as far as I can see.

[talltyler]

You are correct, it looks like socket.io-client is updated and they are still waiting.
Is there a way around these issues until that happens?

[dignifiedquire]

@talltyler you can just use it, they are only optional dependencies that fail when installing, just npm is spitting out way too many warnings about it :(

[kylecordes]

I am also eager to see this updated. I hate to see projects stuck with transitive dependencies holding things back, workarounds can be ugly but I think it is better than being stuck.

[dpsthree]

I ran into this today as well. While I agree with @3rd-Eden it would be nice to have a work around. There is no use attempting to hand wave away errors that aren't actually errors.

[dignifiedquire]

Well the solution would be to have someone properly maintaining socket.io...as we sadly can't switch away from it as it still has the best support for old browsers..

[pmq20]

Adding to the list: nodejs/node#2798.

[dignifiedquire]

@pmq20 why? karma is working fine on 4.0 as stated before only optional dependencies of socket.io are failing

[pmq20]

@dignifiedquire Oh sorry that I missed the fact that this is just a warning-level failure.

[mgol]

FYI: socket.io 1.3.7 is out, it supports Node 4 without any optional deps failing. :) We should get those lines removed from .travis.yml.

[dignifiedquire]

Sweet

[dignifiedquire]

Should be fixed in 0.13.10