-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No error is returned when using a browser that is not installed. #2403
No error is returned when using a browser that is not installed. #2403
Comments
It seems you should install |
That's not the point. The point is given that it is not installed, I should obtain an error. Currently, if you integrate a karma build in some CI environment, if you forget to add the launcher dependency, or if for some reason it doesn't get installed, karma will report this as a success even though none of the tests could actually run! |
I see what you mean. I have got the same error and don't understand why is not documented yet. |
Expected behaviour
Given that the target browser is
PhantomJS
and the plugin package for
PhantomJS
is not installed.When the following code runs:
Then the console should print an error and an error status != 0 like this:
Actual behaviour
The console shows a status 0:
Environment Details
karma --version
): 1.3.0karma.config.js
fileSteps to reproduce the behaviour
See above.
Additional notes
This breaks the recommended usage shown in gulp-karma as the job will exit with status 0 and pass CI checks although no tests actually ran!
The text was updated successfully, but these errors were encountered: