Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karma has a non-dev dependency on chromium (via the puppeteer package) #3191

Closed
davidshepherd7 opened this issue Oct 22, 2018 · 2 comments · Fixed by JetBrains/ring-ui#463, Narshe1412/nuarca-sql#25 or karronoli/redpen#10

Comments

@davidshepherd7
Copy link

This commit added puppeteer (which is a wrapper around headless chrome) as a non-dev dependency of karma. Previously karma had phantomjs-prebuilt as a dev dependency.

Presumably this change was unintentional? It's a bit annoying because it makes the install of karma take a long time.

Expected behaviour

Installing karma does not install any particular browser.

Actual behaviour

Installing karma installs chromium.

Environment Details

  • Karma version (output of karma --version): Karma version: 3.1.0
  • Relevant part of your karma.config.js file: N/A

Steps to reproduce the behaviour

  1. npm install -D karma
@lukehutton
Copy link

lukehutton commented Oct 22, 2018

I am also getting failures on all my builds after doing

npm install -g karma karma-cli bower gulp-cli protractor gulp

Is this relevant?

> puppeteer@1.9.0 install /root/.nvm/versions/node/v8.9.4/lib/node_modules/karma/node_modules/puppeteer
> node install.js

module.js:472
    throw err;
    ^

Error: Cannot find module '/root/.nvm/versions/node/v8.9.4/lib/node_modules/karma/node_modules/puppeteer/install.js'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.runMain (module.js:605:10)
    at run (bootstrap_node.js:427:7)
    at startup (bootstrap_node.js:151:9)
    at bootstrap_node.js:542:3`

downgrading to npm install -g karma@3.0.0 seems to work

@WebTechnolog
Copy link

WebTechnolog commented Oct 22, 2018

puppeteer also takes 303 Mb of disk space which equals to the "weight" of all other packages in my setup (Angular 7 app). It's very annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants