-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for custom context and/or debug html files #1360
feat: Support for custom context and/or debug html files #1360
Conversation
Stumbled upon this from #488. I'm keen on this idea, as I'm struggling with QUnit and es6 module loaders, the problem is QUnit racing against the async module loaders, which appears to mandate something akin to the following as a solution (but as yet untested) https://github.com/jrburke/requirejs/wiki/Test-frameworks#qunit |
I'm trying to migrate our test suite (10,000+) from jasmine-rails to Karma and this would definitely help. A lot of our legacy tests insert into a specific div in our current runner html. |
@jrolfs for what it's worth (and, that's "not much", I know) I "solved" my problem by using https://github.com/opudalo/generator-es6-lib which is a completely different stack of tools…
|
@leehambley thanks for the suggestion (will be useful for other projects 😃), however unfortunately it's not really an option for the project in question. |
Thanks, this looks mostly good, a few things to do please
|
Ok. I will try to fix all of those point as soon as possible. Is it ok if in the end I'll make a new pull request ? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Sure, github doesn't let you change the branch sadly |
Ok. I will mention new pull request here.. |
I signed it! |
CLAs look good, thanks! |
I have applied the changes to the 0.13.9 release here: https://github.com/Sanjo/karma/tree/0.13.9%2Bcustom-context-html. |
|
||
var fileServer; | ||
if (client && client.contextFile) { | ||
fileServer = serveFile; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like the rest of the file follows 2-space indentations; you have 4-space
@sanjo could you open a new pr with your changes please? |
Closing due to inactivity |
Adding support for custom context.html and debug.html
Ref: #488