Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reporter): Ensure errors use the source map #1513

Closed
wants to merge 3 commits into from

Conversation

brianmhunt
Copy link
Contributor

Closes #1495

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@brianmhunt
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@brianmhunt
Copy link
Contributor Author

The CI error being reported is:

  1. launchers/base.js restart should start when already finished (crashed):
    Uncaught AssertionError: expected spy to have been called at least once, but it was never called

Which doesn't look like anything I've done, or in any case it's quite beyond me right now how to address it. :)

@dignifiedquire
Copy link
Member

Which doesn't look like anything I've done, or in any case it's quite beyond me right now how to address it. :)

Don't worry about it, some of our tests are a bit sensitive to travis :(

@dignifiedquire
Copy link
Member

Could you please

@brianmhunt
Copy link
Contributor Author

@dignifiedquire Will do, shortly. Sorry for the oversight. Cheers.

@brianmhunt brianmhunt changed the title Ensure errors use the source map fix(reporter): Ensure errors use the source map Jul 24, 2015
@brianmhunt
Copy link
Contributor Author

@dignifiedquire Test added (and passing) in 7071d0d; not quite sure if I have the convention renaming down. It may need a rebase, which is beyond me. 😁 If needed, do you mind taking care of the commit naming convention?

Thanks & Cheers

@dignifiedquire
Copy link
Member

Thanks, will squash them myself

@dignifiedquire
Copy link
Member

Merged as 0407a22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants