-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reporter): Ensure errors use the source map #1513
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
The CI error being reported is:
Which doesn't look like anything I've done, or in any case it's quite beyond me right now how to address it. :) |
Don't worry about it, some of our tests are a bit sensitive to travis :( |
Could you please
|
@dignifiedquire Will do, shortly. Sorry for the oversight. Cheers. |
@dignifiedquire Test added (and passing) in 7071d0d; not quite sure if I have the convention renaming down. It may need a rebase, which is beyond me. 😁 If needed, do you mind taking care of the commit naming convention? Thanks & Cheers |
Thanks, will squash them myself |
Merged as 0407a22 |
Closes #1495