Add core-js es5 shim to karma client, fixes #1529 #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Thanks, could you change the commit message to follow our convention please? |
Karma client now uses core-js ES5 shim in order to support IE8. Usage of dom-serializer had previously broken IE8 support. Closes karma-runner#1529
kketch
force-pushed
the
fix-karma-client-0.13.0-ie8
branch
from
61fae8c to
14c30b7
Compare
|
Of course :) |
dignifiedquire
added a commit
that referenced
this pull request
Aug 4, 2015
Add core-js es5 shim to karma client, fixes #1529
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added core-js es5 shim in client/main.js
It fixes for me the issue with IE8 which was preventing me to use karma runner to run tests on IE8