-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(config): notice users about optional but used plugin #1555
Conversation
There were the following issues with your Pull Request
Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html This message was auto-generated by https://gitcop.com |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
There were the following issues with your Pull Request
Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html This message was auto-generated by https://gitcop.com |
@@ -14,7 +14,7 @@ You need the following tools installed on your Jenkins CI server: | |||
* Node | |||
* Karma | |||
|
|||
Optional we highly suggest to install the following Jenkins plug-in: | |||
Following Jenkins plugin is optional, but next guidelines are based on it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better: The following Jenkins plugin, but the next guidelines are based on it:
Thanks, there is a space too much in your commit message before the |
There were the following issues with your Pull Request
Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html This message was auto-generated by https://gitcop.com |
Mmmm. Gitcop is amazing but, ... can you help me to fix this one: "https://ci.appveyor.com/project/zzo/karma/build/1.0.175" I followed guidelines. Or not? |
@@ -14,7 +14,7 @@ You need the following tools installed on your Jenkins CI server: | |||
* Node | |||
* Karma | |||
|
|||
Optional we highly suggest to install the following Jenkins plug-in: | |||
The following Jenkins plugin, but the next guidelines are based on it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missed the is optional
@sensorario appveyor isn't properly setup so you can ignore that. The commit message is fine now :) |
Reading that a plugin is optional can make confusion: readers may not install. Readers can not undersand next steps of documentation, base on this plugin.
Thanks |
docs(config): notice users about optional but used plugin
Reading that a plugin is optional can make confusion: readers may not install plugin.
Users can not undersand next steps of documentation, based on this plugin.