Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config): notice users about optional but used plugin #1555

Merged
merged 1 commit into from
Aug 12, 2015
Merged

docs(config): notice users about optional but used plugin #1555

merged 1 commit into from
Aug 12, 2015

Conversation

sensorario
Copy link
Contributor

Reading that a plugin is optional can make confusion: readers may not install plugin.
Users can not undersand next steps of documentation, based on this plugin.

@GitCop
Copy link

GitCop commented Aug 10, 2015

There were the following issues with your Pull Request

  • Commit: e8c1ad8
    • Your commit message body contains a line that is longer than 80 characters
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@GitCop
Copy link

GitCop commented Aug 10, 2015

There were the following issues with your Pull Request

  • Commit: db6f7f9
    • Invalid type. Valid types are feat, fix, docs, style, refactor, test, chore, revert

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@@ -14,7 +14,7 @@ You need the following tools installed on your Jenkins CI server:
* Node
* Karma

Optional we highly suggest to install the following Jenkins plug-in:
Following Jenkins plugin is optional, but next guidelines are based on it:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better: The following Jenkins plugin, but the next guidelines are based on it:

@dignifiedquire
Copy link
Member

Thanks, there is a space too much in your commit message before the (

@GitCop
Copy link

GitCop commented Aug 10, 2015

There were the following issues with your Pull Request

  • Commit: c5463c1
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@sensorario
Copy link
Contributor Author

Mmmm. Gitcop is amazing but, ... can you help me to fix this one: "https://ci.appveyor.com/project/zzo/karma/build/1.0.175"

I followed guidelines. Or not?

@@ -14,7 +14,7 @@ You need the following tools installed on your Jenkins CI server:
* Node
* Karma

Optional we highly suggest to install the following Jenkins plug-in:
The following Jenkins plugin, but the next guidelines are based on it:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed the is optional

@dignifiedquire
Copy link
Member

@sensorario appveyor isn't properly setup so you can ignore that. The commit message is fine now :)

Reading that a plugin is optional can make confusion: readers may not install.
Readers can not undersand next steps of documentation, base on this plugin.
@sensorario sensorario changed the title Notice about optional but used plugin docs(config): notice users about optional but used plugin Aug 11, 2015
@dignifiedquire
Copy link
Member

Thanks :octocat:

dignifiedquire added a commit that referenced this pull request Aug 12, 2015
docs(config): notice users about optional but used plugin
@dignifiedquire dignifiedquire merged commit 378c9e3 into karma-runner:master Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants