Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mime config option support #1735 Fixed #1736

Merged
merged 2 commits into from
Jan 4, 2016
Merged

Mime config option support #1735 Fixed #1736

merged 2 commits into from
Jan 4, 2016

Conversation

comdiv
Copy link
Contributor

@comdiv comdiv commented Dec 1, 2015

No description provided.

@GitCop
Copy link

GitCop commented Dec 1, 2015

There were the following issues with your Pull Request

  • Commit: 90c83c3
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html

This message was auto-generated by https://gitcop.com

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@GitCop
Copy link

GitCop commented Dec 1, 2015

There were the following issues with your Pull Request

  • Commit: b6f0a41
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html

This message was auto-generated by https://gitcop.com

@googlebot
Copy link

CLAs look good, thanks!

@GitCop
Copy link

GitCop commented Dec 1, 2015

There were the following issues with your Pull Request

  • Commit: b824bc4
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html

This message was auto-generated by https://gitcop.com

@comdiv comdiv force-pushed the 1735 branch 2 times, most recently from 8046063 to e62bff8 Compare December 1, 2015 19:23
@GitCop
Copy link

GitCop commented Dec 1, 2015

There were the following issues with your Pull Request

  • Commit: e62bff8
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html

This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Dec 1, 2015

There were the following issues with your Pull Request

  • Commit: 5d61436
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html

This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Dec 1, 2015

There were the following issues with your Pull Request

  • Commit: 24fc90e
    • Your commit message body contains a line that is longer than 80 characters

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html

This message was auto-generated by https://gitcop.com

@dignifiedquire dignifiedquire self-assigned this Dec 1, 2015
@dignifiedquire
Copy link
Member

Thanks, will review tomorrow morning :)

@dignifiedquire
Copy link
Member

Please add some documentation for this as well.

dignifiedquire
dignifiedquire reviewed Dec 2, 2015
View reviewed changes
test/unit/web-server.spec.js
@@ -71,6 +73,10 @@ describe('web-server', () => {
server = injector.invoke(m.createWebServer)
})

it('should setup mime', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test to ensure that the default mimes are still working

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will add

@comdiv comdiv force-pushed the 1735 branch 3 times, most recently from ce325be to 6601703 Compare December 2, 2015 13:18
@comdiv
Copy link
Contributor Author

comdiv commented Dec 2, 2015

test added, config doc updated

comdiv added 2 commits December 3, 2015 03:12
@comdiv
fix(test): locale in Expire header
db04cf0 
Closes karma-runner#1741
@comdiv
feat(config): mime config option support
d562383 
Allows to setup required mime-type to extensions mapping
(for ex. fix default *.ts to video/mp2t mapping)

Closes karma-runner#1735
@dignifiedquire
Copy link
Member

Thanks :octocat:

dignifiedquire added a commit that referenced this pull request Jan 4, 2016
@dignifiedquire
Merge pull request #1736 from comdiv/1735
2010d8a 
Mime config option support #1735 Fixed
@dignifiedquire dignifiedquire merged commit 2010d8a into karma-runner:master Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dignifiedquire dignifiedquire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@comdiv @GitCop @googlebot @dignifiedquire