-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add 'listening' event with port number #1874
feat(server): add 'listening' event with port number #1874
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@googlebot I signed it! |
CLAs look good, thanks! |
Thanks, could you please
|
@dignifiedquire done :) |
|
||
fileListOnResolve() | ||
|
||
server.emit('listening', 9876) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not really testing anything is it? You should probably emit the event on the mockWebServer
instead
I've changed test to pass when |
Thanks :) looks good now, if you could squash your commits into one then I can merge it. |
4d38269
to
82cd0df
Compare
Done :) |
Thanks Just waiting for travis to get green now |
@dignifiedquire It's green |
@karol-f thanks :) |
feat(server): add 'listening' event with port number
@karol-f thanks for the PR |
Sometimes, when you want to use karma port programatically (e.g. to send manually browser to karma localhost: address), you face problem with not knowing exact port number.
Port number might be different from one set in config as sometimes you run more than one instances of karma. Below image show such situation:
This PR adds 'listening' event to karma. After this event you are sure that you have correct karma port number.
You may use it like this: