-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): Add configuration for adding javascript version. #1983
feat(config): Add configuration for adding javascript version. #1983
Conversation
While looking at the Travis CI results, it probably is the fact that Chrome is not available on that server. Should I change this to PhantomJS or is it no issue? /cc @dignifiedquire |
Firefox | ||
""" | ||
|
||
Scenario: Execute a test in Chrome with version, without JavaScript tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be tagged with @not-jenkins
so it's not run on travis
19a8ac7
to
bc7fd1d
Compare
I have successfully made the change that was suggested. It seems that it made the difference and the changes I made actually work now. However, I got the following error (on Jenkins) for the first time ever:
Not sure why it gives an error there, but it has nothing to do with my change. If it is a common, or even new issue, I will create an issue for it 😉 |
Yeah you can ignore that one, no idea why it fails sometimes (was never able to reproduce it locally :( ) |
Ah oke, good. Hope to have helped with this PR ;) |
Thanks, looks good but needs some documentation in the config section of the docs. |
I will write some documentation for it tomorrow. Expect it to have it tomorrow evening. |
Thanks @Moumi |
bc7fd1d
to
c25ed00
Compare
Finished it @dignifiedquire ;) |
|
||
**Description:** The JavaScript version to use in the FireFox browser. | ||
|
||
If `> 0`, Karma will add a JavaScript version tag to the included .js-files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better: "included JavaScript files"
Add the configuration to add a javascript version tag to the loaded scripts. Only applied when the Firefox browser is run. Closes karma-runner#1719.
c25ed00
to
0239c75
Compare
Applied your comments 😉 |
Thanks |
…-tag feat(config): Add configuration for adding javascript version.
Add the configuration to add a javascript version tag to the loaded scripts. Only applied when the Firefox browser is run.
Closes #1719.