Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(browser): add browser_info event #2637

Merged
merged 1 commit into from
Mar 30, 2017
Merged

feat(browser): add browser_info event #2637

merged 1 commit into from
Mar 30, 2017

Conversation

maksimr
Copy link
Contributor

@maksimr maksimr commented Mar 29, 2017

fixes #2192

dignifiedquire
dignifiedquire approved these changes Mar 29, 2017
View reviewed changes
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you, waiting for CI to merge

@maksimr
Copy link
Contributor Author

maksimr commented Mar 29, 2017 •
edited
Loading

@dignifiedquire no problem 👍

This red build on Travis for node@6.x I have fixed in separate PR - #2638
because it's two different things not related each other

@dignifiedquire
Copy link
Member

Thank you :octocat:

@dignifiedquire dignifiedquire merged commit de55bc6 into karma-runner:master Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using 'window.__karma__.info()` API to send arbitrary objects to the server does not work
2 participants
@maksimr @dignifiedquire