Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): show more detailed info about error logged in console #2913

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Conversation

lusarz
Copy link
Contributor

@lusarz lusarz commented Dec 30, 2017

This closes #2854 and closes #2863

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@UniverseHan
Copy link

UniverseHan commented Jan 23, 2018

There are some problems to build. How can it be solved??

@lusarz
Copy link
Contributor Author

lusarz commented Jan 23, 2018

@UniverseHan
I created issue about build problem:
#2915

@dignifiedquire
Copy link
Member

I restarted the build, sad travis was sad

@lusarz
Copy link
Contributor Author

lusarz commented Feb 9, 2018

Travis build fixed.
See problem with AppVeyor, but seems to not be related with this pull request content

@lusarz
Copy link
Contributor Author

lusarz commented Feb 12, 2018

@dignifiedquire
I noticed that AppVeyor fails because it's using master version of useragent (don't know why no one from yarn.lock). I reported this issue in useragent repository:
3rd-Eden/useragent#120

@lusarz
Copy link
Contributor Author

lusarz commented Feb 22, 2018

@dignifiedquire any update on AppVeyor build ? It fails on another pull requests as well.

@dignifiedquire
Copy link
Member

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karma console.log or error work differently. browser console logs miss vital information
4 participants