-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade some deps #2997
Upgrade some deps #2997
Conversation
package.json
Outdated
"socket.io": "2.0.4", | ||
"source-map": "^0.6.1", | ||
"socket.io": "2.1.0", | ||
"source-map": "^0.7.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that the SourceMapConsumer
constructor became asynchronous in source-map
0.7.0. We should change the code where it's used (lib/reporter.js
) accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus the Travis complains:
source-map@0.7.2: The engine "node" is incompatible with this module. Expected version ">= 8".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, there was something.. undid that upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as soon as the CI passes.
Is there any planned progress on this PR? The build has failed, perhaps @dignifiedquire can get some help with this. @johnjbarton can you help or assign someone else? |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
#3044 has just the babel change, and it passes Travis. So I don't know why the last commit here fails. |
@johnjbarton can you restart the Travis build? |
Is there any chance that this PR can be integrated? Even though karma is usually a dev-dependency, getting vulnerability warnings when I locally install some package looks wrong and should never be ignored. |
@dignifiedquire |
Unfortunately I used the wrong version of |
Original fix by @dignifiedquire, muffed in my merge commit.
close/open to see travis |
@johnjbarton: just in case you don't know, you should be able to trigger a build via Travis since you have push rights. :) |
Yes, I've rebuilt this branch many times. It still fails. I'm continuing to work on improving the Travis tests until this passes. |
This is the same as @dignifiedrequire karma-runner#2997 first commit
This is the same as @dignifiedrequire #2997 first commit
I believe that most or all of the fixes on this PR landed via other PRs after travis issues were resolved. Thanks @dignifiedquire! |
This updates the deps that were straightforward to update and some of which
npm audit
was complaining about.