Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade some deps #2997

Closed
wants to merge 7 commits into from
Closed

Upgrade some deps #2997

wants to merge 7 commits into from

Conversation

dignifiedquire
Copy link
Member

This updates the deps that were straightforward to update and some of which npm audit was complaining about.

package.json Outdated
"socket.io": "2.0.4",
"source-map": "^0.6.1",
"socket.io": "2.1.0",
"source-map": "^0.7.2",
Copy link
Contributor

@thorn0 thorn0 May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that the SourceMapConsumer constructor became asynchronous in source-map 0.7.0. We should change the code where it's used (lib/reporter.js) accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus the Travis complains:
source-map@0.7.2: The engine "node" is incompatible with this module. Expected version ">= 8".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, there was something.. undid that upgrade

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as the CI passes.

@tobi-or-not-tobi
Copy link

Is there any planned progress on this PR? The build has failed, perhaps @dignifiedquire can get some help with this. @johnjbarton can you help or assign someone else?

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@johnjbarton
Copy link
Contributor

#3044 has just the babel change, and it passes Travis. So I don't know why the last commit here fails.

@XhmikosR
Copy link
Contributor

@johnjbarton can you restart the Travis build?

@DrRataplan
Copy link

Is there any chance that this PR can be integrated? Even though karma is usually a dev-dependency, getting vulnerability warnings when I locally install some package looks wrong and should never be ignored.

@lusarz
Copy link
Contributor

lusarz commented Jul 25, 2018

@dignifiedquire
It would be nice if you update commit message to make travis-ci pass.

@johnjbarton
Copy link
Contributor

Unfortunately I used the wrong version of mime when I fixed the merge conflicts.

Original fix by @dignifiedquire, muffed in my merge commit.
@johnjbarton
Copy link
Contributor

close/open to see travis

@johnjbarton johnjbarton closed this Aug 6, 2018
@johnjbarton johnjbarton reopened this Aug 6, 2018
@XhmikosR
Copy link
Contributor

XhmikosR commented Aug 7, 2018

@johnjbarton: just in case you don't know, you should be able to trigger a build via Travis since you have push rights. :)

@johnjbarton
Copy link
Contributor

Yes, I've rebuilt this branch many times. It still fails. I'm continuing to work on improving the Travis tests until this passes.

johnjbarton added a commit to johnjbarton/karma that referenced this pull request Aug 8, 2018
This is the same as @dignifiedrequire karma-runner#2997 first commit
johnjbarton added a commit that referenced this pull request Aug 9, 2018
This is the same as @dignifiedrequire #2997 first commit
@johnjbarton
Copy link
Contributor

I believe that most or all of the fixes on this PR landed via other PRs after travis issues were resolved. Thanks @dignifiedquire!

@johnjbarton johnjbarton deleted the deps branch February 20, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants