Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flaky-test): Add time to beforeEach() to allow plugins to load on first pass. #3025

Merged
merged 1 commit into from
Jun 4, 2018
Merged

fix(flaky-test): Add time to beforeEach() to allow plugins to load on first pass. #3025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/unit/server.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ describe('server', () => {
var fileListOnResolve = fileListOnReject = mockLauncher = null
var mockFileList = mockWebServer = mockSocketServer = mockExecutor = doneSpy = null

beforeEach(() => {
// Use regular function not arrow so 'this' is mocha 'this'.
beforeEach(function () {
// The first call to new Server() loads plugins and it can take >2000ms.
this.timeout(4000)
browserCollection = new BrowserCollection()
doneSpy = sinon.spy()

Expand Down