fix(test): update bundleResource test timeout #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjbarton
suggested changes
Jun 11, 2018
| @@ -16,7 +16,7 @@ describe('BundleUtils.bundleResource', () => { | |||
| expect(fs.existsSync(PathUtils.calculateAbsolutePath('test/unit/fixtures/bundled.js'))).to.be.true | |||
| done() | |||
| }) | |||
| }) | |||
| }).timeout(5000) | |||
There was a problem hiding this comment.
How about this.timeout(5000) in the function body (we have 2 other examples like that). I think that form is clearer to read.
There was a problem hiding this comment.
Hmm, for me it(...).timeout(5000) is more readable because allows to separate from test content and test configuration. We are also able to use arrow function in that case.
What about changing other places into that style ?
Although it's detail, so I'm okay with this.timeout() as well
There was a problem hiding this comment.
Ok the arrow function argument convinced me ;-)
johnjbarton
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.