-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): Enable loading different file types when running in parent mode without iframe #3289
Merged
johnjbarton
merged 8 commits into
karma-runner:master
from
chan1cyrus2:fix-script-file-type-in-parent-mode
Apr 12, 2019
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d39167c
fix(client): Includes attributes like type in script tags when runnin…
chan1cyrus2 cd0bf3c
fix(client): Enable loading different file types when running in pare…
chan1cyrus2 5fd685a
fix(client): Update comments on escaping character with special roles…
chan1cyrus2 699f8a5
fix(client): Fix comments
chan1cyrus2 cddb93c
fix(client): Use conditions to make the require changes.
43d9629
fix(client): Fix CLA
chan1cyrus2 905e464
fix(client): Fix CLA second try!
chan1cyrus2 e87e349
fix(client): Fix typo
chan1cyrus2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the different case significant? If yes please add a comment; if no please pick one.