fix(browser): make sure that empty results array is still recognized

[devoto13]

Otherwise empty array is treated as a single value, which causes issues down the road.

[karmarunnerbot]

✅ Build karma 222 completed (commit 352e1d19fd by @devoto13)

[karmarunnerbot]

✅ Build karma 223 completed (commit 352e1d19fd by @devoto13)

[johnjbarton]

I would like to understand the motivation better: this changes behavior in the case that result has zero length. We don't refresh the timer for example.

[devoto13]

You're right. I haven't really looked around the check. I'll investigate if it may cause unintended side effects.

[devoto13]

@johnjbarton I'm pretty sure this will not have unintended side effects. The only case which behaves differently is when result is [] (empty array). Before it would end up emitting spec_complete with [], but the handler expects a single result object and will crash as [].suite is undefined.

[] will not refresh a no activity timeout, but it should not really matter as client does not send [] at the moment and this change is just to add extra safety to avoid a potential crash.

Let me know if you still want me to remove the return, so no activity timeout is refreshed in this case?

[johnjbarton]

yes let's call the refresh.

[karmarunnerbot]

✅ Build karma 229 completed (commit c9b7cf288a by @devoto13)

[karmarunnerbot]

✅ Build karma 228 completed (commit c9b7cf288a by @devoto13)

[devoto13]

@johnjbarton Done

[karmarunnerbot]

🎉 This PR is included in version 5.0.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀