Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add 'md' to FILE_TYPES #3491

Closed
wants to merge 1 commit into from
Closed

refactor: add 'md' to FILE_TYPES #3491

wants to merge 1 commit into from

Conversation

lmlife2016
Copy link

@lmlife2016 lmlife2016 commented Apr 30, 2020

when I use Chai Plugin for Snapshot Testing with Karma, run script 'karma start', there will show some warning like this in terminal: '[middleware:karma]: Invalid file type (md), defaulting to js.'
this change could clear the warning
image

when I use Chai Plugin for Snapshot Testing with Karma, run script 'karma start', there will show some warning like this in terminal: '[middleware:karma]: Invalid file type (md), defaulting to js.'
this change could clear the warning
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@karmarunnerbot
Copy link
Member

Build karma 235 completed (commit 321ea76880 by @lmlife2016)

@AppVeyorBot
Copy link

Build karma 2633 completed (commit 321ea76880 by @lmlife2016)

@karmarunnerbot
Copy link
Member

Build karma 234 completed (commit 321ea76880 by @lmlife2016)

@lmlife2016
Copy link
Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@devoto13
Copy link
Collaborator

devoto13 commented Apr 30, 2020

Thanks for the PR @lmlife2016, but this fix does not seem to be necessary.

You can override type parameter in your Karma config file if you want your .md files to be treated as JS files and included as script tags.

E.g.

    files: [
      { pattern: "**/__snapshots__/**/*.md", type: "js" },
      "__tests__/index.js"
    ],

Let me know if this solves your problem?

@lmlife2016
Copy link
Author

Thanks for the PR @lmlife2016, but this fix does not seem to be necessary.

You can override type parameter in your Karma config file if you want your .md files to be treated as JS files and included as script tags.

E.g.

    files: [
      { pattern: "**/__snapshots__/**/*.md", type: "js" },
      "__tests__/index.js"
    ],

Let me know if this solves your problem?

It's good! Thank you every much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants