Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: back to version 0.6.x of source-map #3558

Closed
wants to merge 1 commit into from
Closed

revert: back to version 0.6.x of source-map #3558

wants to merge 1 commit into from

Conversation

puppe
Copy link

@puppe puppe commented Sep 3, 2020

source-map 0.7.0 has breaking change. As a temporary workaround, this
commit reverts to using version 0.6.x of source-map. See
#3557 for details.

source-map 0.7.0 has breaking change. As a temporary workaround, this
commit reverts to using version 0.6.x of source-map. See
#3557 for details.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@devoto13
Copy link
Collaborator

devoto13 commented Sep 3, 2020

Thanks @puppe!

Please accept the CLA as requested by bot here and change commit message to fix: revert to version 0.6.x of source-map or something. It is important that scope is fix, so it will be automatically released once PR is merged.

@karmarunnerbot
Copy link
Member

Build karma 362 completed (commit 831b369f7c by @puppe)

@AppVeyorBot
Copy link

Build karma 2760 completed (commit 831b369f7c by @puppe)

@karmarunnerbot
Copy link
Member

Build karma 361 completed (commit 831b369f7c by @puppe)

@puppe
Copy link
Author

puppe commented Sep 3, 2020

I don't want to be rude but I only made this pull request because you asked me to. I didn't really understand why you didn't change that single line in package.json yourself. I won't read a CLA for such a minor little thing. And I won't sign anything that I did not read.

@puppe puppe closed this Sep 3, 2020
@devoto13
Copy link
Collaborator

devoto13 commented Sep 3, 2020

@puppe Karma is an open source project and a product of community work. It is nice when people not only report a bug, but also fix it and submit a pull request. So I just offered you to contribute back to the project and start with this small fix. I'll fix it myself if you are not interested in contributing.

@puppe
Copy link
Author

puppe commented Sep 3, 2020

@devoto13 I did not “only report a bug”, I also spent several hours looking for the source of the bug. If that’s not a contribution, I don’t know what is.

This is only a workaround anyway, and does not address the real issue. If you wanted me to fix the real issue eventually, you should have just told me so. And I would have had to tell you that I unfortunately don’t have time for that. This is only a hobby for me. I use Karma on a little project that I forked from somebody else. Node is not my day job.

@devoto13
Copy link
Collaborator

devoto13 commented Sep 3, 2020

@puppe And thank you for researching the issue. I do appreciate it.

I totally understand that not everybody has time to work on fixes, that's why I asked if you're willing to make a PR. In any case #3559 should be merged and released soon.

@puppe
Copy link
Author

puppe commented Sep 3, 2020

@devoto13 Thank you for your work on Karma. I also appreciate that. Have a good one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants