-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ua-parser-js dependency #3564
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
✅ Build karma 2764 completed (commit ebc9a929b0 by @donovanh) |
✅ Build karma 366 completed (commit ebc9a929b0 by @donovanh) |
✅ Build karma 365 completed (commit ebc9a929b0 by @donovanh) |
you should update package-lock file too |
✅ Build karma 2765 completed (commit 8caa33a177 by @) |
✅ Build karma 367 completed (commit 8caa33a177 by @) |
✅ Build karma 366 completed (commit 8caa33a177 by @) |
Also, please squash changes into a single commit and fix a commit message to match guidelines. This should fix the failing CI. Something like: |
✅ Build karma 368 completed (commit dcb1cc98f1 by @donovanh) |
✅ Build karma 2766 completed (commit dcb1cc98f1 by @donovanh) |
✅ Build karma 367 completed (commit dcb1cc98f1 by @donovanh) |
Thank you @devoto13 and @SymbioticKilla 🙇 |
## [5.2.3](v5.2.2...v5.2.3) (2020-09-25) ### Bug Fixes * update us-parser-js dependency ([#3564](#3564)) ([500ed25](500ed25))
🎉 This PR is included in version 5.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [5.2.3](karma-runner/karma@v5.2.2...v5.2.3) (2020-09-25) ### Bug Fixes * update us-parser-js dependency ([karma-runner#3564](karma-runner#3564)) ([500ed25](karma-runner@500ed25))
As noted in this issue,
ua-parser-js
v0.7.21 has a high severity issue.This PR updates the dependency to correct the issue.