Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ua-parser-js dependency #3564

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Conversation

donovanh
Copy link
Contributor

@donovanh donovanh commented Sep 23, 2020

As noted in this issue, ua-parser-js v0.7.21 has a high severity issue.

This PR updates the dependency to correct the issue.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@donovanh
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@AppVeyorBot
Copy link

Build karma 2764 completed (commit ebc9a929b0 by @donovanh)

@karmarunnerbot
Copy link
Member

Build karma 366 completed (commit ebc9a929b0 by @donovanh)

@karmarunnerbot
Copy link
Member

Build karma 365 completed (commit ebc9a929b0 by @donovanh)

@SymbioticKilla
Copy link
Contributor

you should update package-lock file too

@AppVeyorBot
Copy link

Build karma 2765 completed (commit 8caa33a177 by @)

@karmarunnerbot
Copy link
Member

Build karma 367 completed (commit 8caa33a177 by @)

@karmarunnerbot
Copy link
Member

Build karma 366 completed (commit 8caa33a177 by @)

@devoto13
Copy link
Collaborator

Also, please squash changes into a single commit and fix a commit message to match guidelines. This should fix the failing CI.

Something like: fix: update ua-parser-js dependency.

@karmarunnerbot
Copy link
Member

Build karma 368 completed (commit dcb1cc98f1 by @donovanh)

@AppVeyorBot
Copy link

Build karma 2766 completed (commit dcb1cc98f1 by @donovanh)

@karmarunnerbot
Copy link
Member

Build karma 367 completed (commit dcb1cc98f1 by @donovanh)

@donovanh
Copy link
Contributor Author

Thank you @devoto13 and @SymbioticKilla 🙇

@johnjbarton johnjbarton merged commit 500ed25 into karma-runner:master Sep 25, 2020
karmarunnerbot pushed a commit that referenced this pull request Sep 25, 2020
## [5.2.3](v5.2.2...v5.2.3) (2020-09-25)

### Bug Fixes

* update us-parser-js dependency ([#3564](#3564)) ([500ed25](500ed25))
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants