fix(middleware): throw script tag errors

[johnjbarton]

Include failing path. This is important for module tags which otherwise
simply give 404 at the server.

Fixes #3572

[johnjbarton]

@jehon please review

[karmarunnerbot]

✅ Build karma 392 completed (commit b280f298c8 by @johnjbarton)

[AppVeyorBot]

✅ Build karma 2789 completed (commit b280f298c8 by @johnjbarton)

[karmarunnerbot]

✅ Build karma 391 completed (commit b280f298c8 by @johnjbarton)

[jehon]

Yes, this is what I found out yesterday night too...
Please note that the error on console will be shown twice in the case of an error in a "classical" script:

With this change:

Uncaught ReferenceError: <error msg>
ReferenceError: <error msg>
   at failing-test.js:2:1

Instead of before:

ReferenceError: <error msg>
   at failing-test.js:2:1

[johnjbarton]

Hmm. Reference Error is unexpected. I need to add a test that throws.

[johnjbarton]

Added an e2e test.

[karmarunnerbot]

✅ Build karma 396 completed (commit 95aa986f97 by @johnjbarton)

[AppVeyorBot]

✅ Build karma 2793 completed (commit 95aa986f97 by @johnjbarton)

[karmarunnerbot]

✅ Build karma 395 completed (commit 95aa986f97 by @johnjbarton)

[jehon]

@johnjbarton sorry for not being precise... the "ReferenceError" is the internal error in the loaded script. It is the error that I was expecting. Could have been anonymised a bit more...
It is the fact that the same error (referenceerror) appear twice that may be a problem...

[johnjbarton]

Actually the non-module path is a problem, because by default karma loads any unknown file as js. If the config does not match the filesystem, a script error results. Need to fix that up.

[johnjbarton]

This was superceded by #3605