-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): check extension before ts-node register #3651
fix(config): check extension before ts-node register #3651
Conversation
Call require('ts-node').register() after checking configFilePath has `.ts` extension Fixes karma-runner#3329
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
✅ Build karma 2927 completed (commit 4157266d7a by @xel23) |
✅ Build karma 530 completed (commit 4157266d7a by @xel23) |
✅ Build karma 529 completed (commit 4157266d7a by @xel23) |
@xel23 Thanks for the PR! I guess we can land it as a workaround to solve the most painful appearance of this issue, but I don't think it "fixes" the issue. We really should implement a systematic solution as outlined in #3329 (comment). Technically this is a breaking change. People, who might have relied on type-checking their |
Ping |
🎉 This PR is included in version 6.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you so much for fixing this! 🥳 🎉 |
Call require('ts-node').register() after checking configFilePath has `.ts` extension Fixes karma-runner#3329
## [6.1.1](karma-runner/karma@v6.1.0...v6.1.1) (2021-02-12) ### Bug Fixes * **config:** check extension before ts-node register ([karma-runner#3651](karma-runner#3651)) ([474f4e1](karma-runner@474f4e1)), closes [karma-runner#3329](karma-runner#3329) * report launcher process error when exit event is not emitted ([karma-runner#3647](karma-runner#3647)) ([7ab86be](karma-runner@7ab86be))
Call require('ts-node').register() after checking configFilePath has
.ts
extensionFixes #3329
сс @devoto13