-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(plugins): add missing tests for plugin resolution logic #3661
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
✅ Build karma 545 completed (commit b3b8af351b by @devoto13) |
✅ Build karma 544 completed (commit b3b8af351b by @devoto13) |
@googlebot I consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
❌ Build karma 551 failed (commit b95360dd37 by @devoto13) |
❌ Build karma 550 failed (commit b95360dd37 by @devoto13) |
@johnjbarton Can you merge #3659 first? PS I've missed that #3659 was not merged and rebased anyways, that's why build is failing now. |
✅ Build karma 553 completed (commit 379bab16ee by @devoto13) |
@johnjbarton Rebased and should be ready to land now. |
✅ Build karma 552 completed (commit 379bab16ee by @devoto13) |
🎉 This PR is included in version 6.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Depends on and includes #3659 (just want to run CI, for now, will rebase before the merge).