Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugins): add missing tests for plugin resolution logic #3661

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

devoto13
Copy link
Collaborator

@devoto13 devoto13 commented Mar 5, 2021

Depends on and includes #3659 (just want to run CI, for now, will rebase before the merge).

@google-cla
Copy link

google-cla bot commented Mar 5, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@karmarunnerbot
Copy link
Member

Build karma 545 completed (commit b3b8af351b by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 544 completed (commit b3b8af351b by @devoto13)

@hdmr14
Copy link
Contributor

hdmr14 commented Mar 5, 2021

@googlebot I consent.

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@karmarunnerbot
Copy link
Member

Build karma 551 failed (commit b95360dd37 by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 550 failed (commit b95360dd37 by @devoto13)

@devoto13
Copy link
Collaborator Author

devoto13 commented Mar 9, 2021

@johnjbarton Can you merge #3659 first?
Then I'll rebase this PR and we can merge it as well.

PS I've missed that #3659 was not merged and rebased anyways, that's why build is failing now.

@karmarunnerbot
Copy link
Member

Build karma 553 completed (commit 379bab16ee by @devoto13)

@devoto13
Copy link
Collaborator Author

@johnjbarton Rebased and should be ready to land now.

@karmarunnerbot
Copy link
Member

Build karma 552 completed (commit 379bab16ee by @devoto13)

@johnjbarton johnjbarton merged commit d3ff91a into karma-runner:master Mar 11, 2021
@devoto13 devoto13 deleted the plugin-tests branch March 11, 2021 20:22
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants