fix: replace colors with ansi-colors
#3743
Conversation
alan-agius4
force-pushed
the
ansi-colors
branch
from
54f0a7a
to
bf56570
Compare
The author of the colors package purpose broke this package. See: https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/ and Marak/colors.js#285 Closes karma-runner#3738
alan-agius4
force-pushed
the
ansi-colors
branch
from
bf56570
to
c7ec501
Compare
|
Unfortunately, this may be breaking to the plugins relying on the modified string prototype. I remember looking into switching to IMO We should probably stick with pinning for now and replace the library as part of the major release. |
|
Would be great if you could remember the problem that it caused. I am good in replacing in package in a major if you think it’s breaking. |
|
Oh, sorry! I had a tab with the PR opened since earlier and looked at the old code (replacing IIRC There were some third-party plugins relying on |
|
Great 🚀 |
|
Just curious if this should be pinned to an explicit version instead of using the Just doing some dives into the colors issue and being pinned to 1.4.0 before the breaking changes would have added time. But don't want to delay any fixes |
|
The safest solution would be to just set colors to version 1.4.0 and drop the ^ Especially for getting a fix pushed as soon as possible. Then you can switch to ansi-colors when you have time to do some testing |
|
i guess few reporters like spec reporter also use colors |
|
Due to the potential breakages I will mark this PR a WIP. |
|
This PR can be closed in favor of #3763 . |
|
(As an update -- looks like #3763 was successfully merged, so I think this can be closed.) |
Agreed! |
The author of the colors package purpose broke this package.
See: https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/ and Marak/colors.js#285
Closes #3738