fix(launcher): sigkill after sigint if not dead #823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.id = id; | ||
| this.state = null; | ||
| this._tempDir = path.normalize((env.TMPDIR || env.TMP || env.TEMP || '/tmp') + '/karma-' + | ||
| id.toString()); | ||
| this.exitCallbacks = []; |
There was a problem hiding this comment.
Can you make it just a local var (var exitCallbacks)?
And remove the var exitCallback on line 19, as we don't need it anymore...
|
Thanks @lzatorski ! Can you also squash all your changes into a single commit? Did you sign the Google CLA? Again, thanks a lot! |
commit 76847fe Author: Lukasz Zatorski <lzatorski@gmail.com> Date: Fri Nov 15 13:41:04 2013 -0800 fix(launcher): behavior fixed for cleaning tmp directory commit 09dd0d5 Author: Lukasz Zatorski <lzatorski@gmail.com> Date: Wed Nov 13 19:31:43 2013 -0800 fix(launcher): Removed trailing whitespace commit 9653c85 Author: Lukasz Zatorski <lzatorski@gmail.com> Date: Tue Nov 12 19:12:15 2013 -0800 fix(launcher): sigkill after sigint if not dead In some cases chrome on linux does not die when it receives a sigint signal. So after a sigint is sent wait 2 more seconds and issue a sigkill if the process is still running.
|
Hi @vojtajina , I made changes you asked and a fix for correct tmp directory cleaning and squashed all commits together (is it fine?). I signed the Google CLA this morning :) |
|
Thanks @lzatorski ! Merged as c0fa49a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases chrome on linux does not die when it receives a sigint
signal. So after a sigint is sent wait 2 more seconds and issue a
sigkill if the process is still running.