Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local-up-karmada related scripts #106

Open
warjiang opened this issue Sep 4, 2024 · 5 comments
Open

Remove local-up-karmada related scripts #106

warjiang opened this issue Sep 4, 2024 · 5 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@warjiang
Copy link
Contributor

warjiang commented Sep 4, 2024

What would you like to be added:
The local-up-karmada.sh is inherited from karmada main repo, for the reason that we want to skip the process of building binary and building image. After the stage of rapid development of new karmada dashboard, we want to remove local-up-karmada, and let the karmada repo maintain local-up-karmada related implementation avoid loose reponsibility.

Why is this needed:
After inherited local-up-karmada.sh from karmada main repo, we found that there is no need to maintain two similar code in two repo, remove local-up-karmada related scripts and reuse the code in karmada repo make it more maintainable, and we can focus on the development of karmada dashboard

@warjiang warjiang added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 4, 2024
@RainbowMango
Copy link
Member

Just a short update:

karmada-io/karmada#5627 introduced an option to allow hack/local-up-karmada.sh to use the published latest images directly, bypassing the build process.

So, we can move this forward now.

@warjiang
Copy link
Contributor Author

Looks great 🚀 . Prepare to try the new hack/local-up-karmada.sh in the main repo, after that I'll move this feature forward.

@warjiang
Copy link
Contributor Author

/assign

@warjiang
Copy link
Contributor Author

i've checked the install by pre-build images feature in the main repo, and met some problems, the issuse: karmada-io/karmada#5812

@warjiang
Copy link
Contributor Author

another problems is that, will the karmada main repo support install from pre-build images with offline mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants