Allow hack/local-up-karmada.sh to use latest pre-built images
#5627
Conversation
…allation Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/M
| kind load docker-image "${REGISTRY}/karmada-aggregated-apiserver:${VERSION}" --name="${HOST_CLUSTER_NAME}" | ||
| kind load docker-image "${REGISTRY}/karmada-search:${VERSION}" --name="${HOST_CLUSTER_NAME}" | ||
| kind load docker-image "${REGISTRY}/karmada-metrics-adapter:${VERSION}" --name="${HOST_CLUSTER_NAME}" | ||
| if [[ "${BUILD_FROM_SOURCE}" == "true" ]]; then |
There was a problem hiding this comment.
I wander if I can update this line to if [[ "${BUILD_FROM_SOURCE}" != "false" ]] when judge whether need kind load
There was a problem hiding this comment.
I think we should try to avoid double-negative confusion.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5627 +/- ##
==========================================
- Coverage 35.20% 35.19% -0.01%
==========================================
Files 645 645
Lines 44869 44869
==========================================
- Hits 15795 15791 -4
- Misses 27844 27847 +3
- Partials 1230 1231 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/retitle Allow |
karmada-bot
changed the title
hack/local-up-karmada.sh to use latest pre-built images
|
The This PR introduces an option to allow the script to use the published latest images directly, bypassing the build process. This change will significantly reduce the setup time for local environments and provide convenience for users who do not need frequent updates to their codebase. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
supports specifying whether need making local images in local up installation
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Usage:
# BUILD_FROM_SOURCE=false hack/local-up-karmada.shDoes this PR introduce a user-facing change?: