Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default image tag #103

Merged

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates and corrects the default image tag.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

The steps to run the quick start demo would be:

  1. launch Karmada: hack/local-up-karmada.sh
  2. switch to host cluster and apply dashboards:
export KUBECONFIG=${HOME}/.kube/karmada.config
kubectl config use-context karmada-host

kubectl apply -f artifacts/dashboard/karmada-dashboard-sa.yaml
kubectl apply -f artifacts/dashboard/karmada-dashboard-api.yaml
kubectl apply -f artifacts/dashboard/karmada-dashboard-web.yaml
kubectl apply -f artifacts/dashboard/karmada-dashboard-configmap.yaml
  1. expose the dashboard port to host:
kubectl port-forward -n karmada-system services/karmada-dashboard-web --address 0.0.0.0 8000:8000
  1. launch dashboard by http://<host-ip>:8000
  2. get the token
export KUBECONFIG=${HOME}/.kube/karmada.config
kubectl config use-context karmada-apiserver
kubectl apply -f artifacts/dashboard/karmada-dashboard-sa.yaml
kubectl -n karmada-system get secret/karmada-dashboard-secret -ojsonpath='{.data.token}' | base64 -d && echo

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 4, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2024
@RainbowMango RainbowMango mentioned this pull request Sep 4, 2024
@warjiang
Copy link
Contributor

warjiang commented Sep 4, 2024

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@karmada-bot karmada-bot merged commit d487cbe into karmada-io:main Sep 4, 2024
4 checks passed
@RainbowMango RainbowMango deleted the pr_update_default_image_tag branch September 4, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants