Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #130

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Remove unused code #130

merged 1 commit into from
Sep 25, 2024

Conversation

iawia002
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The previous code and directory also made me feel confused. I saw that #107 had not been updated for a long time, so I submitted this PR.

Which issue(s) this PR fixes:
Fixes #107

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

/cc @warjiang

Signed-off-by: Xinzhao Xu <z2d@jifangcheng.com>
@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 24, 2024
@warjiang
Copy link
Contributor

/assign

@warjiang
Copy link
Contributor

thks~

@warjiang
Copy link
Contributor

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@karmada-bot karmada-bot merged commit d218bea into karmada-io:main Sep 25, 2024
6 checks passed
@iawia002 iawia002 deleted the rm branch September 25, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the old implementation of dashboard
3 participants