Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add route to get member cluster node #146

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Add route to get member cluster node #146

merged 3 commits into from
Nov 20, 2024

Conversation

Heylosky
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Currently our company is using karmada as a company-level cluster management platform. We plan to display more information on the dashboard and add some new features, such as the ability to display member-cluster-node information. This PR adds the ability to obtain member-cluster-node information through the karmada-dashboard-api component, in preparation for adding a UI page.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
In our usage scenario, the member cluster is isolated from the main cluster. We hope to display more information about the member cluster through the dashboard, such as deployment, pod, namespace, etc., not just the resources deployed by karmada. Please consider whether it can be added to future plans.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 30, 2024
@karmada-bot
Copy link
Collaborator

Welcome @Heylosky! It looks like this is your first PR to karmada-io/dashboard 🎉

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2024
@Heylosky
get member cluster node
8be6169 
Signed-off-by: Heylosky <2547226479@qq.com>
@Heylosky Heylosky force-pushed the member-cluster-node branch from 6f3ccde to eb985e6 Compare October 30, 2024 03:02
@RainbowMango
Copy link
Member

Hi @Heylosky Thanks for spotting and doing this.
I wonder if you will attend this week's community meeting, we can talk about it there.
You can find the meeting link at https://github.com/karmada-io/dashboard?tab=readme-ov-file#meeting.

@Heylosky
Copy link
Contributor Author

Hi @Heylosky Thanks for spotting and doing this. I wonder if you will attend this week's community meeting, we can talk about it there. You can find the meeting link at https://github.com/karmada-io/dashboard?tab=readme-ov-file#meeting.

OK.

@Heylosky Heylosky force-pushed the member-cluster-node branch 2 times, most recently from e6af8c4 to 866c7ea Compare October 30, 2024 11:31
@Heylosky
add get member cluster node
6135bb1 
Signed-off-by: Heylosky <2547226479@qq.com>
@Heylosky Heylosky force-pushed the member-cluster-node branch from 866c7ea to 6135bb1 Compare October 30, 2024 11:36
warjiang
warjiang reviewed Nov 13, 2024
View reviewed changes
@Heylosky
Optimiz get member apiserver nodes
64f2fde 
Signed-off-by: Heylosky <2547226479@qq.com>
@Heylosky Heylosky requested a review from warjiang November 14, 2024 09:38
@warjiang
Copy link
Contributor

/lgtm
/approve
thanks @Heylosky

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@karmada-bot karmada-bot merged commit 062da64 into karmada-io:main Nov 20, 2024
6 checks passed
warjiang
warjiang reviewed Nov 20, 2024
View reviewed changes
pkg/client/init.go
@@ -233,6 +254,43 @@ func InClusterClientForKarmadaApiServer() kubeclient.Interface {
return inClusterClientForKarmadaApiServer
}

func InClusterClientForMemberCluster(clusterName string) kubeclient.Interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warjiang warjiang warjiang left review comments

@devadapter devadapter Awaiting requested review from devadapter

@jhnine jhnine Awaiting requested review from jhnine

Assignees

@warjiang warjiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Heylosky @karmada-bot @RainbowMango @warjiang