add fallback value to i18n and fix inconsistent probelm #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/XXL
RainbowMango
added
the
tide/merge-method-squash
RainbowMango
approved these changes
Jan 15, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimize i18n usage and fix inconsistent language problem
/kind bug
/kind cleanup
What this PR does / why we need it:
i18n.t('6860e13ac48e930f8076ebfe37176b78'), now we add the fallback valuei18n.t('6860e13ac48e930f8076ebfe37176b78', '节点数量'), i will make the i18n translation more robust for any scenario of network.Which issue(s) this PR fixes:
Fixes Inconsistent Language Display in Karmada Dashboard #161
Special notes for your reviewer:
this PR will be hard to review it carefully, because we changed the usage of i18n method acrocss the whole project, so just go ahead, and i've checked the inconsistent problems locally.
here is the screenshot:
Does this PR introduce a user-facing change?: