chore: format code about errcheck,gosimple,ineffassign,unused #188
Conversation
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/L
| os.Exit(0) | ||
| } | ||
| <-ctx.Done() | ||
| os.Exit(0) | ||
| return nil |
There was a problem hiding this comment.
cmd/api/app/api.go:114:2: S1000: should use a simple channel send/receive instead of select with a single case (gosimple)
|
/cc @warjiang |
chaosi-zju
force-pushed
the
staticcheck2
branch
from
31acb5b to
be73193
Compare
karmada-bot
added
size/M
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
chaosi-zju
force-pushed
the
staticcheck2
branch
from
be73193 to
3408ec7
Compare
karmada-bot
added
size/L
chaosi-zju
changed the title
| os.Exit(0) | ||
| } | ||
| <-ctx.Done() | ||
| os.Exit(0) | ||
| return nil |
|
/lgtm |
|
@chaosi-zju Just revied the PR, it seems ok, any more update on |
no more~ |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: warjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
chore: format code about errcheck,gosimple,ineffassign,unused
Which issue(s) this PR fixes:
Fixes part of karmada-io/karmada#6078
Special notes for your reviewer:
Does this PR introduce a user-facing change?: