Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DASHBOARD: Add github workflow used to build the karmada-dashboard image #5

Merged
merged 1 commit into from
Jan 6, 2022
Merged

DASHBOARD: Add github workflow used to build the karmada-dashboard image #5

merged 1 commit into from
Jan 6, 2022

Conversation

devadapter
Copy link
Contributor

Fixes issue: dashboard#4

@karmada-bot
Copy link
Collaborator

Welcome @devadapter! It looks like this is your first PR to karmada-io/dashboard 🎉

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 5, 2022
@devadapter devadapter changed the title DASHBOARD: Add github workflow used to build the karmada-dashboard image #4 DASHBOARD: Add github workflow used to build the karmada-dashboard image Jan 5, 2022
RainbowMango
RainbowMango reviewed Jan 5, 2022
View reviewed changes
.github/workflows/push-image.yml Outdated
Comment on lines 6 to 7
pull_request:
branches: [main]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull_request:
branches: [main]

We shouldn't publish images on PR since the PR hasn't gotten approved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will publish images only after PR gets merged to main branch.

@RainbowMango
Copy link
Member

@devadapter can we add a makefile and users can run make images to build images then make upload-images to any registry they specified.

We can refer to Karmada Makefile:
https://github.com/karmada-io/karmada/blob/master/Makefile
And the workflow:
https://github.com/karmada-io/karmada/blob/master/.github/workflows/image.yml

@devadapter
Copy link
Contributor Author

@devadapter can we add a makefile and users can run make images to build images then make upload-images to any registry they specified.

We can refer to Karmada Makefile: https://github.com/karmada-io/karmada/blob/master/Makefile And the workflow: https://github.com/karmada-io/karmada/blob/master/.github/workflows/image.yml

This workflow pushes images to different registry based on secret variables, if you need to switch to Makefile, I'll write about it later as I'm not familiar with it

@devadapter
Add GitHub workflow used to build the karmada-dashboard image
a247ecc 
Signed-off-by: dev <cossjie@foxmail.com>
@RainbowMango
Copy link
Member

This workflow pushes images to different registry based on secret variables, if you need to switch to Makefile, I'll write about it later as I'm not familiar with it

OK.

@RainbowMango
Copy link
Member

I'm going to merge this workflow first.

@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango RainbowMango added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@karmada-bot karmada-bot merged commit 214f5c7 into karmada-io:main Jan 6, 2022
@RainbowMango RainbowMango mentioned this pull request Jan 28, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devadapter @karmada-bot @RainbowMango