-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize the generation of certificates for karmadactl init #2297
Standardize the generation of certificates for karmadactl init #2297
Conversation
370fd31
to
ea292bd
Compare
Unify format
|
ea292bd
to
ffe16af
Compare
I will review it ASAP this week. |
Signed-off-by: lonelyCZ <531187475@qq.com>
ffe16af
to
818a9e3
Compare
/cc @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
for @lonelyCZ confirm
Have you tested it?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, it works fine in my environment. |
Thanks. |
Signed-off-by: lonelyCZ 531187475@qq.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #2282
Special notes for your reviewer:
Does this PR introduce a user-facing change?: