Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the generation of certificates for karmadactl init #2297

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

lonelyCZ
Copy link
Member

@lonelyCZ lonelyCZ commented Aug 1, 2022

Signed-off-by: lonelyCZ 531187475@qq.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

[root@master67 karmada]# tree
.
├── crds
│   ├── bases
│   │   ├── config.karmada.io_resourceinterpreterwebhookconfigurations.yaml
│   │   ├── multicluster.x-k8s.io_serviceexports.yaml
│   │   ├── multicluster.x-k8s.io_serviceimports.yaml
│   │   ├── networking.karmada.io_multiclusteringresses.yaml
│   │   ├── policy.karmada.io_clusteroverridepolicies.yaml
│   │   ├── policy.karmada.io_clusterpropagationpolicies.yaml
│   │   ├── policy.karmada.io_federatedresourcequotas.yaml
│   │   ├── policy.karmada.io_overridepolicies.yaml
│   │   ├── policy.karmada.io_propagationpolicies.yaml
│   │   ├── work.karmada.io_clusterresourcebindings.yaml
│   │   ├── work.karmada.io_resourcebindings.yaml
│   │   └── work.karmada.io_works.yaml
│   ├── kustomization.yaml
│   └── patches
│       ├── webhook_in_clusterresourcebindings.yaml
│       └── webhook_in_resourcebindings.yaml
├── crds.tar.gz
├── karmada-agent.yaml
├── karmada-apiserver.config
├── karmada-scheduler-estimator.yaml
└── pki
    ├── ca.crt
    ├── ca.key
    ├── etcd-ca.crt
    ├── etcd-ca.key
    ├── etcd-client.crt
    ├── etcd-client.key
    ├── etcd-server.crt
    ├── etcd-server.key
    ├── front-proxy-ca.crt
    ├── front-proxy-ca.key
    ├── front-proxy-client.crt
    ├── front-proxy-client.key
    ├── karmada.crt
    └── karmada.key

Which issue(s) this PR fixes:
Part of #2282

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 1, 2022
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 1, 2022
@lonelyCZ lonelyCZ force-pushed the pr-init-normalize-cert branch from 370fd31 to ea292bd Compare August 2, 2022 06:05
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2022
@lonelyCZ
Copy link
Member Author

lonelyCZ commented Aug 2, 2022

Unify format

[root@master67 karmada]# tree
.
├── crds.tar.gz
├── karmada-agent.yaml
├── karmada-apiserver.config
├── karmada-scheduler-estimator.yaml
└── pki
    ├── apiserver.crt
    ├── apiserver.key
    ├── ca.crt
    ├── ca.key
    ├── etcd-ca.crt
    ├── etcd-ca.key
    ├── etcd-client.crt
    ├── etcd-client.key
    ├── etcd-server.crt
    ├── etcd-server.key
    ├── front-proxy-ca.crt
    ├── front-proxy-ca.key
    ├── front-proxy-client.crt
    ├── front-proxy-client.key
    ├── karmada.crt
    └── karmada.key

@lonelyCZ lonelyCZ force-pushed the pr-init-normalize-cert branch from ea292bd to ffe16af Compare August 3, 2022 02:26
@carlory
Copy link
Member

carlory commented Aug 4, 2022

I will review it ASAP this week.

Signed-off-by: lonelyCZ <531187475@qq.com>
@lonelyCZ lonelyCZ force-pushed the pr-init-normalize-cert branch from ffe16af to 818a9e3 Compare August 16, 2022 07:35
@lonelyCZ
Copy link
Member Author

/cc @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
for @lonelyCZ confirm
Have you tested it?

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2022
@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@lonelyCZ
Copy link
Member Author

Have you tested it?

Yes, it works fine in my environment.

@RainbowMango
Copy link
Member

Thanks.
/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2022
@karmada-bot karmada-bot merged commit 822abc5 into karmada-io:master Aug 18, 2022
@lonelyCZ lonelyCZ deleted the pr-init-normalize-cert branch August 21, 2022 09:25
@RainbowMango RainbowMango added this to the v1.3 milestone Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants