Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update karmada's k8s components to 1.25.2 #2539

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Update karmada's k8s components to 1.25.2 #2539

merged 3 commits into from
Sep 23, 2022

Conversation

jwcesign
Copy link
Member

@jwcesign jwcesign commented Sep 19, 2022 •
edited
Loading

Signed-off-by: jwcesign jiangwei115@huawei.com

What type of PR is this?

/kind feature

What this PR does / why we need it:
Update karmada's dependent k8s karmada to latest version/1.25.2

Test results:
local-up-karmada.sh deploy way:
image
image

kubectl karmada init deploy way:
image

helm deploy way:
image

Which issue(s) this PR fixes:
Update karmada's dependent k8s karmada to latest version/1.25.2

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

karmadactl/chart: if karmada is installed by using karmadactl or helm chart with default configuration, the image version of karmada-kube-controller-manager/karmada-apiserver will be kube-controller-manager:v1.25.2/kube-apiserver:v1.25.2.

@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 19, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2022
@RainbowMango
Copy link
Member

@jwcesign Does this ready for moving forward? there is still a WIP in the PR title.

@jwcesign
Copy link
Member Author

jwcesign commented Sep 20, 2022 •
edited
Loading

@jwcesign Does this ready for moving forward? there is still a WIP in the PR title.

Stil a WIP PR, I am woring about karmadactl init

@jwcesign jwcesign changed the title [WIP] Update karmada's k8s components to 1.25.1 Update karmada's k8s components to 1.25.1 Sep 20, 2022
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 20, 2022
@XiShanYongYe-Chang
Copy link
Member

This pr needs to wait for #2547 and #2548
/hold

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2022
@RainbowMango
Copy link
Member

By the way, are you going to update the version for the chart?
I'm asking because I see this patch including both development and karmadactl, just the chart left. I'm ok to do it by separated PR, just make sure the chart part is still on your plan.

jwcesign added 2 commits September 22, 2022 15:48
Update karmada's k8s components to 1.25.1 for loca-up-karmada.sh
8e37317 
Signed-off-by: jwcesign <jiangwei115@huawei.com>
Update k8s dependency to latest version(1.25.1) for karmadactl
a6d26b2 
Signed-off-by: jwcesign <jiangwei115@huawei.com>
@jwcesign jwcesign force-pushed the master branch 2 times, most recently from c77d7e6 to 66c7f28 Compare September 22, 2022 11:07
@jwcesign jwcesign requested review from RainbowMango and removed request for Garrybest September 22, 2022 12:11
@RainbowMango
Copy link
Member

I think we need a release note as the behavior changed for both karmadactl and chart that they now default to a newer version.

@RainbowMango
Copy link
Member

I just found that Kuberentes has released v1.25.2 which fixed a kube-apiserver bug. (See this notes).

So, could you please update to v1.25.2?

Update helm install karmada with k8s 1.25.1
d8a35e2 
Signed-off-by: jwcesign <jiangwei115@huawei.com>
@jwcesign jwcesign changed the title Update karmada's k8s components to 1.25.1 Update karmada's k8s components to 1.25.2 Sep 23, 2022
RainbowMango
RainbowMango approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@RainbowMango
Copy link
Member

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@karmada-bot karmada-bot merged commit ed13e66 into karmada-io:master Sep 23, 2022
@jwcesign jwcesign mentioned this pull request Oct 17, 2022
Closed
8 tasks
@zhzhuang-zju zhzhuang-zju mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwcesign @RainbowMango @XiShanYongYe-Chang @karmada-bot