-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karmadactl taint uses factory to access cluster #2610
karmadactl taint uses factory to access cluster #2610
Conversation
5f347b5
to
3a795f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2610 +/- ##
==========================================
+ Coverage 23.81% 23.84% +0.02%
==========================================
Files 184 184
Lines 18502 18488 -14
==========================================
+ Hits 4407 4408 +1
+ Misses 13749 13735 -14
+ Partials 346 345 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
flags.BoolVar(&o.overwrite, "overwrite", o.overwrite, "If true, allow taints to be overwritten, otherwise reject taint updates that overwrite existing taints.") | ||
flags.BoolVar(&o.DryRun, "dry-run", false, "Run the command in dry-run mode, without making any server requests.") | ||
flags.StringVar(defaultConfigFlags.KubeConfig, "kubeconfig", *defaultConfigFlags.KubeConfig, "Path to the kubeconfig file to use for CLI requests.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @jwcesign comment on https://github.com/karmada-io/karmada/pull/2611/files
Can we extract these duplicated codes ? @carlory
thanks, I will review it tomorrow. |
ed161ed
to
3a795f1
Compare
fe568f8
to
2f34d1f
Compare
2f34d1f
to
222663e
Compare
Hi, @helen-frank , please rebase it. /assign |
Signed-off-by: helen <helenfrank@protonmail.com>
222663e
to
619c9b6
Compare
/cc @lonelyCZ |
Thanks @helen-frank , It works fine in my env. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lonelyCZ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes #
Part of#2349
Special notes for your reviewer:
Test
go run ./cmd/karmadactl/karmadactl.go --kubeconfig /etc/karmada/karmada-apiserver.config taint clusters kind-multi-node1 bar:NoSchedule cluster/kind-multi-node1 tainted kubectl --kubeconfig /etc/karmada/karmada-apiserver.config get clusters kind-multi-node1 -oyaml | grep -C 5 taints namespace: karmada-cluster secretRef: name: kind-multi-node1 namespace: karmada-cluster syncMode: Push taints: - effect: NoSchedule key: bar status: apiEnablements: - groupVersion: admissionregistration.k8s.io/v1 go run ./cmd/karmadactl/karmadactl.go --kubeconfig /etc/karmada/karmada-apiserver.config taint clusters kind-multi-node1 bar:NoSchedule- cluster/kind-multi-node1 untainted
Does this PR introduce a user-facing change?: