-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase .metadata.generation
once desired state of the Cluster
object is changed.
#3241
Increase .metadata.generation
once desired state of the Cluster
object is changed.
#3241
Conversation
0f5d06d
to
ccbd947
Compare
ccbd947
to
5324ff3
Compare
Signed-off-by: changzhen <changzhen5@huawei.com>
5324ff3
to
a4753cd
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3241 +/- ##
==========================================
+ Coverage 49.15% 49.20% +0.05%
==========================================
Files 206 206
Lines 18377 18388 +11
==========================================
+ Hits 9033 9048 +15
+ Misses 8856 8853 -3
+ Partials 488 487 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@Garrybest @chaunceyjiang Do you have any other comments?
You are not |
karmada-aggregated-apiserver
: Increase .metadata.generation
once desired state of the Cluster
object is changed.
karmada-aggregated-apiserver
: Increase .metadata.generation
once desired state of the Cluster
object is changed..metadata.generation
once desired state of the Cluster
object is changed.
@XiShanYongYe-Chang Have you tested it? Please share a test report here. |
No, LGTM |
Before update: apiVersion: cluster.karmada.io/v1alpha1
kind: Cluster
metadata:
creationTimestamp: "2023-03-06T12:24:41Z"
finalizers:
- karmada.io/cluster-controller
generation: 5
name: member1
resourceVersion: "804"
uid: c2b697d0-d9cc-4e32-982b-eb7c3f50082d
spec:
apiEndpoint: https://172.18.0.4:6443
id: 668b5146-f8f3-4592-847a-a79c34106193
impersonatorSecretRef:
name: member1-impersonator
namespace: karmada-cluster
... When I update the cluster apiEndpoint field, after: apiVersion: cluster.karmada.io/v1alpha1
kind: Cluster
metadata:
creationTimestamp: "2023-03-06T12:24:41Z"
finalizers:
- karmada.io/cluster-controller
generation: 6
name: member1
resourceVersion: "844527"
uid: c2b697d0-d9cc-4e32-982b-eb7c3f50082d
spec:
apiEndpoint: https://172.18.0.4:6444
id: 668b5146-f8f3-4592-847a-a79c34106193
impersonatorSecretRef:
name: member1-impersonator
namespace: karmada-cluster
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
We should set the
generation
field of the Cluster object. When thespec
part of the Cluster object changes, thegeneration
value should increase. Its value begins with 1.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Do we need to pay attention to the changes in labels and annotations of the Cluster object?
Does this PR introduce a user-facing change?: