response actual resource list from search api

[tedli]

What type of PR is this?

/kind feature

What this PR does / why we need it:

response actual resource list, then client code like client-go can decode response body into object corresponding to pre defined api type.

Which issue(s) this PR fixes:
Fixes #3311

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-search`: response actual resource list from search API.

[XiShanYongYe-Chang]

/assign

[XiShanYongYe-Chang]

Thanks~
Can you help post your test result?

[codecov-commenter]

Codecov Report

Merging #3312 (97872b4) into master (6647508) will increase coverage by 10.11%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master    #3312       +/-   ##
===========================================
+ Coverage   38.98%   49.10%   +10.11%     
===========================================
  Files         207      209        +2     
  Lines       19365    18763      -602     
===========================================
+ Hits         7549     9213     +1664     
+ Misses      11360     9049     -2311     
- Partials      456      501       +45     

Flag	Coverage Δ
unittests	49.10% <0.00%> (+10.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/registry/search/storage/cache.go	0.00% <0.00%> (ø)
pkg/registry/search/storage/search.go	0.00% <0.00%> (ø)

... and 68 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[tedli]

Thanks~ Can you help post your test result?

You mean unit test? Or something like, I make a POC demo, to make sure the idea of this pr works as expect?

[XiShanYongYe-Chang]

You mean unit test? Or something like, I make a POC demo, to make sure the idea of this pr works as expect?

Sorry, I didn't make it clear, just referring to a simple access and return result.

[tedli]

Hi @XiShanYongYe-Chang

[XiShanYongYe-Chang]

Thanks~
/lgtm
Can you help update the release note like that:

`karmada-search`: response actual resource list from search api

[XiShanYongYe-Chang]

/cc @RainbowMango
Can you help to run the CI?

[tedli]

podlist.mp4

type response[T runtime.Object] struct {
	metav1.TypeMeta   `json:",inline"`
	metav1.ObjectMeta `json:"metadata,omitempty"`
	Items             []T
}

func listPod(client kubernetes.Interface) {
	// var raw []byte
	var raw runtime.Object
	var err error
	if raw, err = client.CoreV1().RESTClient().Get().RequestURI(
		fmt.Sprintf("/apis/search.karmada.io/v1alpha1/search/cache/api/v1/namespaces/%s/pods", "lizhen6")).
		//DoRaw(context.Background()); err != nil {
		Do(context.Background()).Get(); err != nil {
		panic(err)
	}
	//var pods response[*corev1.Pod]
	//if err = json.Unmarshal(raw, &pods); err != nil {
	//	panic(err)
	//}
	pods, ok := raw.(*corev1.PodList)
	if !ok {
		panic("not pod list")
	}
	fmt.Printf("===== List Pod =====\n")
	for _, item := range pods.Items {
		fmt.Printf("Kind: %s, Name: %s, Namespace: %s, Annotations[\"resource.karmada.io/cached-from-cluster\"]: %s\n",
			kind(item), item.Name, item.Namespace, item.Annotations["resource.karmada.io/cached-from-cluster"])
	}
}

func kind(obj interface{}) string {
	return reflect.Indirect(reflect.ValueOf(obj)).Type().Name()
}

[XiShanYongYe-Chang]

@tedli, thanks very much, the test you provided was very detailed

[tedli]

Thanks~ /lgtm Can you help update the release note like that:

`karmada-search`: response actual resource list from search api

Do you mean add a CHANGELOG-1.6.md at docs\CHANGELOG and mention this in it? If so would the next release be 1.6 or other lucky number?

[XiShanYongYe-Chang]

Do you mean add a CHANGELOG-1.6.md at docs\CHANGELOG and mention this in it? If so would the next release be 1.6 or other lucky number?

I'm referring to this place:

[XiShanYongYe-Chang]

An occasional error occurred in the CLI test, not related to the current modification.

Hi @tedli, can you squash your two commit into one commit?

[tedli]

An occasional error occurred in the CLI test, not related to the current modification.

Hi @tedli, can you squash your two commit into one commit?

Done.

[XiShanYongYe-Chang]

Thanks~
/lgtm
/approve

[XiShanYongYe-Chang]

/assign @RainbowMango

[RainbowMango]

/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RainbowMango]

@tedli I just noticed that GitHub can't recognize you by your email in the commit(author part).
If you want GitHub to count your contribution, please add your email to GitHub Emails, note that doesn't mean you have to public your email, it still can be private.

[tedli]

@tedli I just noticed that GitHub can't recognize you by your email in the commit(author part). If you want GitHub to count your contribution, please add your email to GitHub Emails, note that doesn't mean you have to public your email, it still can be private.

Thanks. I've updated, adding the email in git commit to github.

[RainbowMango]

Thanks. OK now.